Phase 2 security audit follow-up. Three independent hardenings against the unauthenticated daemon surface, the long-lived agent SSE stream and the self-update channel. UPnP is now opt-in. The stream port + /hls endpoints have no auth, so publishing them on the WAN via the gateway was a default that exposed active downloads to anyone scanning the operator's external IP. New config downloads.enable_upnp (default false) gates the mapping; LAN and Tailscale clients continue to work unchanged. A startup log makes the new default visible. The agent SSE reader now uses a bounded bufio.Scanner instead of an unbounded ReadString. A hostile or buggy server can no longer grow daemon memory by streaming a single line forever or by emitting unbounded data: continuation lines — both are capped at 256 KiB and 1 MiB respectively, and an error is surfaced so SignalLoop reconnects. Self-update now verifies an ed25519 signature over checksums.txt when the binary was built with a release public key embedded (injected via goreleaser ldflags from RELEASE_SIGNING_PUBKEY). The companion scripts/sign-checksums runs in the release workflow when both the public-key variable and the private-key secret are present, uploading checksums.txt.sig next to the existing checksums file. Builds without the embedded key continue to update with SHA256-only verification; a --allow-unsigned flag is provided so users on a signed build can still install pre-signing releases or recover from an accidental unsigned release. A new scripts/gen-release-key helper documents the one-time keypair generation procedure required before flipping signing on.
217 lines
6.2 KiB
Go
217 lines
6.2 KiB
Go
package upgrade
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"context"
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
"strings"
|
|
"time"
|
|
)
|
|
|
|
var httpClient = &http.Client{Timeout: 120 * time.Second}
|
|
|
|
const (
|
|
maxDownloadRetries = 3
|
|
retryBaseDelay = 5 * time.Second
|
|
)
|
|
|
|
// retryDelays returns the wait duration before the nth retry (1-based).
|
|
// Delays: 5s, 15s — increasing gap to avoid hammering on transient failures.
|
|
func retryDelay(attempt int) time.Duration {
|
|
return retryBaseDelay * time.Duration(attempt*attempt)
|
|
}
|
|
|
|
// downloadWithRetry fetches the release archive, retrying on transient errors.
|
|
// onProgress is called with user-facing messages (may be nil).
|
|
func downloadWithRetry(ctx context.Context, version string, onProgress func(string)) (string, error) {
|
|
var lastErr error
|
|
for attempt := 1; attempt <= maxDownloadRetries; attempt++ {
|
|
path, err := download(ctx, version)
|
|
if err == nil {
|
|
return path, nil
|
|
}
|
|
lastErr = err
|
|
if attempt < maxDownloadRetries {
|
|
delay := retryDelay(attempt)
|
|
if onProgress != nil {
|
|
onProgress(fmt.Sprintf("Download failed (%v)", err))
|
|
onProgress(fmt.Sprintf("Retrying in %s... (attempt %d/%d)", delay, attempt+1, maxDownloadRetries))
|
|
}
|
|
select {
|
|
case <-ctx.Done():
|
|
return "", ctx.Err()
|
|
case <-time.After(delay):
|
|
}
|
|
}
|
|
}
|
|
return "", lastErr
|
|
}
|
|
|
|
// download fetches the release archive to a temporary file.
|
|
func download(ctx context.Context, version string) (string, error) {
|
|
url := releaseURL(version, archiveName(version))
|
|
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
req.Header.Set("User-Agent", "unarr-updater")
|
|
|
|
resp, err := httpClient.Do(req)
|
|
if err != nil {
|
|
return "", fmt.Errorf("fetch %s: %w", url, err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != http.StatusOK {
|
|
return "", fmt.Errorf("fetch %s: HTTP %d", url, resp.StatusCode)
|
|
}
|
|
|
|
tmp, err := os.CreateTemp("", "unarr-download-*.tmp")
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
defer tmp.Close()
|
|
|
|
if _, err := io.Copy(tmp, resp.Body); err != nil {
|
|
os.Remove(tmp.Name())
|
|
return "", fmt.Errorf("write archive: %w", err)
|
|
}
|
|
|
|
return tmp.Name(), nil
|
|
}
|
|
|
|
// verifyChecksum downloads checksums.txt and verifies the archive's SHA256.
|
|
// When a release public key is embedded at build time (releasePubKeyBase64),
|
|
// the function also verifies an ed25519 signature over checksums.txt before
|
|
// trusting any hash inside it — this turns the checksum file from a passive
|
|
// integrity check into an authenticated artifact that a maintainer or CI key
|
|
// compromise cannot trivially forge.
|
|
func verifyChecksum(ctx context.Context, version, archivePath string) error {
|
|
return verifyChecksumWithOptions(ctx, version, archivePath, true)
|
|
}
|
|
|
|
// verifyChecksumOnly skips the ed25519 signature step. Used by Upgrader
|
|
// when --allow-unsigned is set and the release is known to predate signing
|
|
// (or when a release accidentally shipped without a .sig file).
|
|
func verifyChecksumOnly(ctx context.Context, version, archivePath string) error {
|
|
return verifyChecksumWithOptions(ctx, version, archivePath, false)
|
|
}
|
|
|
|
func verifyChecksumWithOptions(ctx context.Context, version, archivePath string, verifySignature bool) error {
|
|
// Download checksums.txt
|
|
url := releaseURL(version, "checksums.txt")
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
req.Header.Set("User-Agent", "unarr-updater")
|
|
|
|
resp, err := httpClient.Do(req)
|
|
if err != nil {
|
|
return fmt.Errorf("fetch checksums: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != http.StatusOK {
|
|
return fmt.Errorf("fetch checksums: HTTP %d", resp.StatusCode)
|
|
}
|
|
|
|
// Read the entire checksums.txt content first so we can both parse and
|
|
// verify the signature over the same bytes.
|
|
checksumsContent, err := io.ReadAll(io.LimitReader(resp.Body, 1<<20))
|
|
if err != nil {
|
|
return fmt.Errorf("read checksums: %w", err)
|
|
}
|
|
|
|
// Verify ed25519 signature over checksums.txt before trusting its
|
|
// contents. Skipped silently when no key is embedded (handled by the
|
|
// caller via SignatureVerificationConfigured) or when the caller
|
|
// explicitly opts out via --allow-unsigned.
|
|
if verifySignature {
|
|
if err := verifyChecksumsSignature(ctx, version, checksumsContent); err != nil {
|
|
return fmt.Errorf("verify signature: %w", err)
|
|
}
|
|
}
|
|
|
|
// Parse checksums.txt — format: "<sha256> <filename>"
|
|
expectedName := archiveName(version)
|
|
var expectedHash string
|
|
|
|
scanner := bufio.NewScanner(bytes.NewReader(checksumsContent))
|
|
for scanner.Scan() {
|
|
line := scanner.Text()
|
|
parts := strings.Fields(line)
|
|
if len(parts) >= 2 && parts[1] == expectedName {
|
|
expectedHash = parts[0]
|
|
break
|
|
}
|
|
}
|
|
if err := scanner.Err(); err != nil {
|
|
return fmt.Errorf("read checksums: %w", err)
|
|
}
|
|
|
|
if expectedHash == "" {
|
|
return fmt.Errorf("no checksum found for %s in checksums.txt", expectedName)
|
|
}
|
|
|
|
// Compute SHA256 of the downloaded archive
|
|
f, err := os.Open(archivePath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer f.Close()
|
|
|
|
h := sha256.New()
|
|
if _, err := io.Copy(h, f); err != nil {
|
|
return fmt.Errorf("hash archive: %w", err)
|
|
}
|
|
|
|
actualHash := hex.EncodeToString(h.Sum(nil))
|
|
if !strings.EqualFold(actualHash, expectedHash) {
|
|
return fmt.Errorf("SHA256 mismatch: expected %s, got %s", expectedHash, actualHash)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// fetchLatestVersion queries GitHub API for the latest release tag.
|
|
func fetchLatestVersion(ctx context.Context) (string, error) {
|
|
url := fmt.Sprintf("https://api.github.com/repos/%s/releases/latest", githubRepo)
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
req.Header.Set("Accept", "application/vnd.github+json")
|
|
req.Header.Set("User-Agent", "unarr-updater")
|
|
|
|
resp, err := httpClient.Do(req)
|
|
if err != nil {
|
|
return "", fmt.Errorf("fetch latest release: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != http.StatusOK {
|
|
return "", fmt.Errorf("GitHub API: HTTP %d", resp.StatusCode)
|
|
}
|
|
|
|
var release struct {
|
|
TagName string `json:"tag_name"`
|
|
}
|
|
if err := json.NewDecoder(resp.Body).Decode(&release); err != nil {
|
|
return "", fmt.Errorf("decode response: %w", err)
|
|
}
|
|
|
|
if release.TagName == "" {
|
|
return "", fmt.Errorf("empty tag_name in release")
|
|
}
|
|
|
|
return strings.TrimPrefix(release.TagName, "v"), nil
|
|
}
|